Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable limit to number of blocks to check before Bigtable upload (backport #24716) #25185

Merged
merged 1 commit into from
May 13, 2022

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 13, 2022

This is an automatic backport of pull request #24716 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

…pload (#24716)

* Add ConfirmedBlockUploadConfig, no behavior changes

* Add comment

* A little DRY cleanup

* Add configurable limit to number of blocks to check in Blockstore and Bigtable before uploading

* Limit blockstore and bigtable look-ahead

* Exit iterator early when reach ending_slot

* Use rooted_slot_iterator instead of slot_meta_iterator

* Only check blocks in the ledger

(cherry picked from commit bc005e3)
@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label May 13, 2022
@mergify
Copy link
Contributor Author

mergify bot commented May 13, 2022

automerge label removed due to a CI failure

@mergify mergify bot added automerge Merge this Pull Request automatically once CI passes and removed automerge Merge this Pull Request automatically once CI passes labels May 13, 2022
@mergify mergify bot merged commit ead8409 into v1.10 May 13, 2022
@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #25185 (86ecd7a) into v1.10 (d1bde17) will increase coverage by 0.0%.
The diff coverage is 86.2%.

@@           Coverage Diff            @@
##            v1.10   #25185    +/-   ##
========================================
  Coverage    81.5%    81.5%            
========================================
  Files         588      590     +2     
  Lines      160624   161024   +400     
========================================
+ Hits       130961   131295   +334     
- Misses      29663    29729    +66     

@mergify mergify bot deleted the mergify/bp/v1.10/pr-24716 branch May 13, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant