-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add version getter to VersionedTransaction class #27734
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27734 +/- ##
=========================================
+ Coverage 76.9% 77.3% +0.4%
=========================================
Files 48 55 +7
Lines 2505 2889 +384
Branches 355 402 +47
=========================================
+ Hits 1927 2234 +307
- Misses 448 514 +66
- Partials 130 141 +11 |
mergify
bot
removed
the
automerge
Merge this Pull Request automatically once CI passes
label
Sep 12, 2022
automerge label removed due to a CI failure |
jstarry
force-pushed
the
web3/versioned-tx-version
branch
from
September 13, 2022 00:16
1b6a946
to
08e3e1f
Compare
This was referenced Oct 4, 2022
This was referenced Oct 28, 2022
This was referenced Nov 9, 2022
This was referenced Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When differentiating between
VersionedTransaction
andTransaction
, it's a little awkward to useif ('message' in transaction')
. It'd be more natural to check for the existence of aversion
property.Summary of Changes
Expose
VersionedTransaction.message.version
with a newversion
getter functionFixes #