Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add version getter to VersionedTransaction class #27734

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Sep 12, 2022

Problem

When differentiating between VersionedTransaction and Transaction, it's a little awkward to use if ('message' in transaction'). It'd be more natural to check for the existence of a version property.

Summary of Changes

Expose VersionedTransaction.message.version with a new version getter function

Fixes #

@jstarry jstarry added the automerge Merge this Pull Request automatically once CI passes label Sep 12, 2022
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #27734 (08e3e1f) into master (e779032) will increase coverage by 0.4%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #27734     +/-   ##
=========================================
+ Coverage    76.9%    77.3%   +0.4%     
=========================================
  Files          48       55      +7     
  Lines        2505     2889    +384     
  Branches      355      402     +47     
=========================================
+ Hits         1927     2234    +307     
- Misses        448      514     +66     
- Partials      130      141     +11     

@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Sep 12, 2022
@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2022

automerge label removed due to a CI failure

@jstarry jstarry force-pushed the web3/versioned-tx-version branch from 1b6a946 to 08e3e1f Compare September 13, 2022 00:16
@jstarry jstarry added the automerge Merge this Pull Request automatically once CI passes label Sep 13, 2022
@mergify mergify bot merged commit d9b1ebe into solana-labs:master Sep 13, 2022
@jstarry jstarry deleted the web3/versioned-tx-version branch September 13, 2022 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants