Replace hardcoded loaded accounts size limit with compute budget instruction #30506
Conversation
tao-stones
added
feature-gate
Thanks @brooksprumo, add a test to check |
runtime/src/accounts.rs
Outdated
| macro_rules! test { | ||
| ( $instructions: expr, $feature_set: expr, $expected_result: expr ) => { | ||
| let payer_keypair = Keypair::new(); | ||
| let tx = SanitizedTransaction::from_transaction_for_tests(Transaction::new( | ||
| &[&payer_keypair], | ||
| Message::new($instructions, Some(&payer_keypair.pubkey())), | ||
| Hash::default(), | ||
| )); | ||
| assert_eq!( | ||
| $expected_result, | ||
| Accounts::get_requested_loaded_accounts_data_size_limit(&tx, $feature_set) | ||
| ); | ||
| }; | ||
| } |
There was a problem hiding this comment.
nit: Can this be a function instead of a macro? (It can still stay within this test too!)
There was a problem hiding this comment.
not sure if macro is worse than function-in-function here, in term of styling. Assume prefer functions because macro is not type checked?
There was a problem hiding this comment.
And macros take longer to compile :)
There was a problem hiding this comment.
but quicker to run 💨 😅
There was a problem hiding this comment.
For the extra time it spent during compile, macros are expanded and inlined. So for the extra compile time and larger size, macros would shave few execution time. Worth it or not perhaps is another debate 😸
There was a problem hiding this comment.
Is it different than #[inline(always)]?
…get instruction; 2. new transaction error for invalid account data size limit
tao-stones
force-pushed
the
loaded_account_size_limit_by_ix
branch
from
a5a4de4 to
3e2eb86
Compare
…ruction (solana-labs#30506) 1. replace hardcoded loaded accounts data size limit with compute budget instruction; 2. new transaction error for invalid account data size limit 3. test requested limit with combination of features and transactions
Problem
#30366 added compute budget instruction to request transaction's loaded accounts size limit. Should replace hardcoded limit with this instruction.
Summary of Changes
Fix: #30366