Add arg boot-from-local-state, enable it in validator #30859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #30859 +/- ##
=========================================
- Coverage 81.5% 81.4% -0.1%
=========================================
Files 731 731
Lines 207379 207436 +57
=========================================
+ Hits 169032 169037 +5
- Misses 38347 38399 +52 |
brooksprumo
reviewed
Mar 23, 2023
brooksprumo
reviewed
Mar 24, 2023
brooksprumo
reviewed
Mar 24, 2023
brooksprumo
reviewed
Mar 24, 2023
brooksprumo
reviewed
Mar 24, 2023
xiangzhu70
force-pushed
the
arg_snapshot_from_dir
branch
from
9ff5485 to
2f0f921
Compare
brooksprumo
reviewed
Mar 24, 2023
xiangzhu70
changed the title
xiangzhu70
force-pushed
the
arg_snapshot_from_dir
branch
2 times, most recently
from
eb2f3ae to
9987e98
Compare
brooksprumo
reviewed
Apr 4, 2023
brooksprumo
reviewed
Apr 4, 2023
brooksprumo
reviewed
Apr 4, 2023
|
Please note that force-pushing in GitHub PRs makes it difficult to track changes. This is exacerbated with many commits within a PR, and increases the amount of time it takes for me to review/re-review. Unless there's a merge conflict, please avoid force pushing. |
xiangzhu70
force-pushed
the
arg_snapshot_from_dir
branch
from
a4e459b to
fcf653c
Compare
brooksprumo
reviewed
Apr 5, 2023
brooksprumo
reviewed
Apr 5, 2023
brooksprumo
reviewed
Apr 5, 2023
brooksprumo
reviewed
Apr 7, 2023
xiangzhu70
force-pushed
the
arg_snapshot_from_dir
branch
from
d882e25 to
e91650c
Compare
xiangzhu70
changed the title
xiangzhu70
force-pushed
the
arg_snapshot_from_dir
branch
from
cb99350 to
0b7cc81
Compare
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This is the last one of the PRs split from 28745.
After #30171, the functionality is available. This PR adds the command line argument, to allow invoking the functionality.
Summary of Changes
Add the argument "boot-from-local-state";
Call bank_from_latest_snapshot_dir first. If it fails, fall back to booting from latest_archive
Purge the snapshot dirs before the call.
Tested
the local cluster on macbook, success and fallback paths.
./multinode-demo/setup.sh
./multinode-demo/bootstrap-validator.sh
hack ledger-tool to use the main paths (not the .ledger-tool paths).
ledger-tool verify
validator on mainnet-beta
without --boot-from-local-state
[2023-03-24T01:12:46.078234944Z INFO solana_runtime::snapshot_utils] snapshot untar took 109.8s
[2023-03-24T01:12:52.014499164Z INFO solana_runtime::snapshot_utils] incremental snapshot untar took 5.9s
[2023-03-24T01:15:05.145936633Z INFO solana_runtime::snapshot_utils] rebuild bank from snapshots took 133.1s
with --boot-from-local-state
[2023-03-24T00:58:20.726576741Z INFO solana_runtime::snapshot_utils] build storage from snapshot dir took 14.9s
[2023-03-24T01:00:10.734562642Z INFO solana_runtime::snapshot_utils] rebuild bank from snapshots took 110.0s
Fixes #