Clear the account paths before constructing a bank from a snapshot dir #31170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31170 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 728 728
Lines 205767 205767
=======================================
+ Hits 167800 167824 +24
+ Misses 37967 37943 -24 |
xiangzhu70
added a commit
to xiangzhu70/solana
that referenced
this pull request
Apr 12, 2023
xiangzhu70
added a commit
to xiangzhu70/solana
that referenced
this pull request
Apr 13, 2023
xiangzhu70
added a commit
that referenced
this pull request
Apr 13, 2023
* bank_from_latest_snapshot_dir * Clear the account paths before constructing a bank from a snapshot dir * Clear the account paths before constructing a bank from a snapshot dir (#31170) * use the highest POST snapshot dir to construct a bank * Use POST to fix test_bank_from_latest_snapshot_dir * Revert "Clear the account paths before constructing a bank from a snapshot dir" This reverts commit 272bb9f. * Remove the set_accounts_hash_for_tests call * Revert "Revert "Clear the account paths before constructing a bank from a snapshot dir"" This reverts commit 2e345d8.
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Apr 14, 2023
jeffwashington
pushed a commit
to jeffwashington/solana
that referenced
this pull request
Apr 14, 2023
* bank_from_latest_snapshot_dir * Clear the account paths before constructing a bank from a snapshot dir * Clear the account paths before constructing a bank from a snapshot dir (solana-labs#31170) * use the highest POST snapshot dir to construct a bank * Use POST to fix test_bank_from_latest_snapshot_dir * Revert "Clear the account paths before constructing a bank from a snapshot dir" This reverts commit 272bb9f. * Remove the set_accounts_hash_for_tests call * Revert "Revert "Clear the account paths before constructing a bank from a snapshot dir"" This reverts commit 2e345d8.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
bank_from_snapshot_dir requires cleaning the <account_path>. It is cleaner to put this necessary cleaning into the function to avoid duplicate the cleaning code before each call.
This addresses the review comment. #31115 (comment)
Summary of Changes
Added the cleaning code in the function bank_from_snapshot_dir
Removed the cleaning code in the test.
Fixes #