Remove bank_snapshots_dir param #31249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #31249 +/- ##
=======================================
Coverage 81.5% 81.5%
=======================================
Files 729 729
Lines 206621 206626 +5
=======================================
+ Hits 168484 168519 +35
+ Misses 38137 38107 -30 |
This reverts commit e444143.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
From suggestion in #30978 (comment), use a split PR to remove the bank_snapshots_dir in a few functions. The reason is that it can be derived from bank_snapshot_info.
Summary of Changes
Remove the param in new_from_snapshot() and the related calling functions.
Added SnapshotError::InvalidSnapshotDirPath to handle parent() error.
Fixes #