Replay Stage start_leader() can use wrong parent fork() #3238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rob-solana
reviewed
Mar 12, 2019
core/src/poh_recorder.rs
Outdated
| pub fn bank(&self) -> Option<Arc<Bank>> { | ||
| self.working_bank.clone().map(|w| w.bank) | ||
| } | ||
| pub fn tick_height(&self) -> u64 { | ||
| self.poh.tick_height | ||
| } | ||
| pub fn ticks_per_slot(&self) -> u64 { | ||
| self.ticks_per_slot | ||
| } | ||
| // synchronize PoH with a bank | ||
| pub fn reset(&mut self, tick_height: u64, blockhash: Hash) { |
There was a problem hiding this comment.
how about passing both slot and tick_height to this function instead? might obviate the need for storing ticks_per_slot in poh_recorder
…ly the biggest indexed bank in frozen_slots()
rob-solana
reviewed
Mar 12, 2019
core/src/replay_stage.rs
Outdated
| @@ -179,58 +189,55 @@ impl ReplayStage { | |||
| bank_forks: &Arc<RwLock<BankForks>>, | |||
| poh_recorder: &Arc<Mutex<PohRecorder>>, | |||
| cluster_info: &Arc<RwLock<ClusterInfo>>, | |||
| blocktree: &Blocktree, | |||
| ticks_per_slot: u64, | |||
There was a problem hiding this comment.
looks like you need to calculate a slot, why not do this above?
Codecov Report
@@ Coverage Diff @@
## master #3238 +/- ##
========================================
- Coverage 81.5% 81.4% -0.1%
========================================
Files 131 131
Lines 19920 19954 +34
========================================
+ Hits 16238 16259 +21
- Misses 3682 3695 +13 |
carllin
added a commit
to carllin/solana
that referenced
this pull request
Mar 13, 2019
…3238) * Make sure start_leader starts on the last voted block, not necessarily the biggest indexed bank in frozen_slots() * Fix tvu test
solana-grimes
pushed a commit
that referenced
this pull request
Mar 13, 2019
* Make sure start_leader starts on the last voted block, not necessarily the biggest indexed bank in frozen_slots() * Fix tvu test
buffalojoec
pushed a commit
to buffalojoec/solana
that referenced
this pull request
Oct 22, 2024
* build(deps): bump anyhow from 1.0.89 to 1.0.90 Bumps [anyhow](https://github.com/dtolnay/anyhow) from 1.0.89 to 1.0.90. - [Release notes](https://github.com/dtolnay/anyhow/releases) - [Commits](dtolnay/anyhow@1.0.89...1.0.90) --- updated-dependencies: - dependency-name: anyhow dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update all Cargo files --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently in start_leader(), the "parent" bank of any newly started TPU is the "greatest" bank in the set of all frozen banks.
However, in our current code, we can vote for slots out of order:
For instance, we could vote for slot 21, and then later vote for slot 19 on a different fork. Then
when we start up a TPU later, we assume slot 21 is the parent, even though the PohRecorder started from slot 19
Summary of Changes
Derive the slot instead based on the first tick stored in the PohRecorder cache
Fixes #