Don't vote for empty leader transmissions #3269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllin
changed the title
* Don't vote for empty leader transmissions * Add is_delta flag to bank to detect empty leader transmissions * Plumb new is_votable flag through replay stage * Fix PohRecorder tests * Change is_delta to AtomicBool to avoid making Bank references mutable * Reset start slot in poh_recorder when working bank is cleared, so that connsecutive TPU's will start from the correct place * Use proper max tick height calculation * Test for not voting on empty transmission * tests for is_votable
|
😱 New commits were pushed while the automerge label was present. |
solana-grimes
removed
the
automerge
Codecov Report
@@ Coverage Diff @@
## v0.12 #3269 +/- ##
=======================================
+ Coverage 74.9% 80.6% +5.6%
=======================================
Files 131 131
Lines 21336 19900 -1436
=======================================
+ Hits 15989 16041 +52
+ Misses 5347 3859 -1488 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## v0.12 #3269 +/- ##
=======================================
+ Coverage 74.9% 80.6% +5.6%
=======================================
Files 131 131
Lines 21336 19900 -1436
=======================================
+ Hits 15989 16041 +52
+ Misses 5347 3859 -1488 |
brooksprumo
added a commit
to brooksprumo/solana
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't vote for empty leader transmissions
Add is_delta flag to bank to detect empty leader transmissions
Plumb new is_votable flag through replay stage
Fix PohRecorder tests
Change is_delta to AtomicBool to avoid making Bank references mutable
Reset start slot in poh_recorder when working bank is cleared, so that connsecutive TPU's will start from the correct place
Use proper max tick height calculation
Test for not voting on empty transmission
tests for is_votable
Problem
Summary of Changes
Fixes #