single pass through each storage to populate info #33227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffwashington
force-pushed
the
sp19_2
branch
from
f682b81 to
0902bae
Compare
jeffwashington
force-pushed
the
sp19_2
branch
3 times, most recently
from
86ff5e4 to
08d0227
Compare
HaoranYi
reviewed
Sep 13, 2023
jeffwashington
force-pushed
the
sp19_2
branch
from
08d0227 to
b024953
Compare
Codecov Report
@@ Coverage Diff @@
## master #33227 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 789 789
Lines 213988 213993 +5
=======================================
+ Hits 175392 175409 +17
+ Misses 38596 38584 -12 |
HaoranYi
approved these changes
Sep 13, 2023
| storage_size_accounts_map_flatten_time.stop(); | ||
|
|
||
| let mut timings = timings.lock().unwrap(); | ||
| timings.storage_size_accounts_map_us += storage_size_accounts_map_time.as_us(); |
There was a problem hiding this comment.
nit: looks like these two timings can be removed, don't need to be done in this pr though.
it can be done with a follow up pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
speeding up index generation on startup
Summary of Changes
go from 2 passes 1 through each account in each append vec
Fixes #