Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disk idx: apply_grow_index does not delete index file #33384

Merged
merged 1 commit into from
Sep 24, 2023

Conversation

jeffwashington
Copy link
Contributor

Problem

working on speeding up startup
Reusing disk index files on restart.

Summary of Changes

apply_grow_index does not delete index file if we plan to re-use the file.

Fixes #

Copy link
Contributor

@HaoranYi HaoranYi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #33384 (1049e9a) into master (c750ac5) will decrease coverage by 0.1%.
The diff coverage is 50.0%.

@@            Coverage Diff            @@
##           master   #33384     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         797      797             
  Lines      216283   216286      +3     
=========================================
- Hits       177327   177326      -1     
- Misses      38956    38960      +4     

@jeffwashington jeffwashington merged commit 27f59e8 into solana-labs:master Sep 24, 2023
15 checks passed
jeffwashington added a commit to jeffwashington/solana that referenced this pull request Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants