Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code clean up #33417

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Code clean up #33417

merged 1 commit into from
Sep 26, 2023

Conversation

HaoranYi
Copy link
Contributor

Problem

Code clean up.

Summary of Changes

  1. remove unneeded pub.
  2. remove unneeded mod.

Fixes #

jeffwashington
jeffwashington approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@HaoranYi HaoranYi added the automerge Merge this Pull Request automatically once CI passes label Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #33417 (585e449) into master (ddd0297) will decrease coverage by 0.1%.
Report is 3 commits behind head on master.
The diff coverage is 66.6%.

@@            Coverage Diff            @@
##           master   #33417     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         798      798             
  Lines      217101   217100      -1     
=========================================
- Hits       178015   177962     -53     
- Misses      39086    39138     +52

@mergify mergify bot merged commit e088eb2 into solana-labs:master Sep 26, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffwashington jeffwashington jeffwashington approved these changes

Assignees
No one assigned
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HaoranYi @jeffwashington