Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initialize with new VoteState for tests #33518

Merged
merged 1 commit into from
Oct 4, 2023
Merged

initialize with new VoteState for tests #33518

merged 1 commit into from
Oct 4, 2023

Conversation

AshwinSekar
Copy link
Contributor

@AshwinSekar AshwinSekar commented Oct 4, 2023 •
edited
Loading

Problem

Now that clusters are on 1.16 and the feature flag is set to be activated soon, it's fine to use the new vote state format for tests.

Summary of Changes

Update with new vote state format for tests. Should not affect any live functionality.

Fixes #33517

@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

Merging #33518 (5889e02) into master (c9d04bc) will increase coverage by 0.0%.
Report is 1 commits behind head on master.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           master   #33518   +/-   ##
=======================================
  Coverage    81.7%    81.7%           
=======================================
  Files         802      802           
  Lines      217872   217874    +2     
=======================================
+ Hits       178144   178161   +17     
+ Misses      39728    39713   -15

@AshwinSekar AshwinSekar marked this pull request as ready for review October 4, 2023 14:22
bji
bji approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@bji bji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally onboard with de-tangling some of this code now that it is no longer necessary to include support for the oldest versions of these data structures.

steveluscher
steveluscher approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@steveluscher steveluscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG yes thank you so much. This will eliminate a major source of flakiness in the web3.js tests.

@AshwinSekar AshwinSekar merged commit d4941cc into solana-labs:master Oct 4, 2023
16 checks passed
@AshwinSekar AshwinSekar deleted the vote-state-init branch October 4, 2023 15:59
@joncinque
Copy link
Contributor

Should this get backported to 1.17 at least?

@AshwinSekar AshwinSekar added the v1.17 PRs that should be backported to v1.17 label Oct 4, 2023
@AshwinSekar
Copy link
Contributor Author

ah yeah good call

mergify bot pushed a commit that referenced this pull request Oct 4, 2023
@AshwinSekar @mergify
initialize with new VoteState for tests (#33518)
9c3d7ff 
(cherry picked from commit d4941cc)
@mergify mergify bot mentioned this pull request Oct 4, 2023
Merged
mergify bot added a commit that referenced this pull request Oct 4, 2023
@mergify @AshwinSekar
v1.17: initialize with new VoteState for tests (backport of #33518) (#…
2bfe99c 
…33531)

initialize with new VoteState for tests (#33518)

(cherry picked from commit d4941cc)

Co-authored-by: Ashwin Sekar <ashwin@solana.com>
tao-stones pushed a commit to tao-stones/solana that referenced this pull request Oct 6, 2023
@AshwinSekar @tao-stones
initialize with new VoteState for tests (solana-labs#33518)
8ad96d5
@HaoranYi HaoranYi mentioned this pull request Apr 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bji bji bji approved these changes

@steveluscher steveluscher steveluscher approved these changes

Assignees
No one assigned
Labels
v1.17 PRs that should be backported to v1.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] vote account should be initialized to modern schema upon starting solana-test-validator in 1.16
4 participants
@AshwinSekar @joncinque @steveluscher @bji