Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes unnecessary borrow #33539

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Removes unnecessary borrow #33539

merged 1 commit into from
Oct 5, 2023

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Oct 5, 2023 •
edited
Loading

Problem

There's an unnecessary borrow that next-nightly clippy complains about. It needs to be resolved to upgrade the nightly Rust version.

Summary of Changes

Remove the unnecessary borrow.

@brooksprumo brooksprumo self-assigned this Oct 5, 2023
@brooksprumo brooksprumo added the v1.17 PRs that should be backported to v1.17 label Oct 5, 2023
@brooksprumo brooksprumo marked this pull request as ready for review October 5, 2023 15:45
apfitzge
apfitzge approved these changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@apfitzge apfitzge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unlike std::fs:read_dir, fs_err::read_dir takes an Into<PathBuf>.
So by referencing here, we were cloning our PathBuf; removing the reference gets rid of that cloning.

@brooksprumo brooksprumo added the automerge Merge this Pull Request automatically once CI passes label Oct 5, 2023
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Oct 5, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 5, 2023

automerge label removed due to a CI failure

@brooksprumo brooksprumo merged commit e0091d6 into solana-labs:master Oct 5, 2023
16 checks passed
@brooksprumo brooksprumo deleted the rust/1.73.0/clippy branch October 5, 2023 16:41
mergify bot pushed a commit that referenced this pull request Oct 5, 2023
@brooksprumo @mergify
Removes unnecessary borrow (#33539)
af89492 
(cherry picked from commit e0091d6)
@mergify mergify bot mentioned this pull request Oct 5, 2023
Merged
brooksprumo added a commit that referenced this pull request Oct 5, 2023
@mergify @brooksprumo
v1.17: Removes unnecessary borrow (backport of #33539) (#33541)
05bbaf3 
(cherry picked from commit e0091d6)

Co-authored-by: Brooks <brooks@solana.com>
@HaoranYi HaoranYi mentioned this pull request Apr 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apfitzge apfitzge apfitzge approved these changes

@ilya-bobyr ilya-bobyr Awaiting requested review from ilya-bobyr

@yihau yihau Awaiting requested review from yihau

Assignees

@brooksprumo brooksprumo

Labels
v1.17 PRs that should be backported to v1.17
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brooksprumo @apfitzge