Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the changelog for v1.18 #33636

Merged
merged 2 commits into from
Oct 11, 2023
Merged

Update the changelog for v1.18 #33636

merged 2 commits into from
Oct 11, 2023

Conversation

willhickey
Copy link
Contributor

Summary of Changes

  • Advanced the channels (should have been done when I branched v1.17 🤦)
  • Update the instructions
    • Added missing instruction
    • Re-ordered instructions so they match the order of the parts of the log they relate to

@willhickey willhickey requested a review from t-nelson October 10, 2023 19:32
Copy link
Contributor

@t-nelson t-nelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

will this be well-formed enough that we could enforce that the changelog conforms with the current channel configuration?

@willhickey
Copy link
Contributor Author

will this be well-formed enough that we could enforce that the changelog conforms with the current channel configuration?

Yes. I've been pondering exactly what that should look like, and the best way to automate the maintenance here. We obviously wouldn't update the changelog in obsolete branches. There's a judgement call whether to leave out of date info or remove it somewhere during the lifecycle. On #33638 I removed the channel links from the v1.17 version (happy to debate that decision on that PR).

I'll do the maintenance manually for a little longer to dial in the correct behavior before I automate it.

@willhickey willhickey merged commit cd743dc into solana-labs:master Oct 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants