adds metrics to repair QUIC endpoint #33818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #33818 +/- ##
========================================
Coverage 81.8% 81.9%
========================================
Files 809 809
Lines 217712 217828 +116
========================================
+ Hits 178295 178437 +142
+ Misses 39417 39391 -26 |
behzadnouri
force-pushed
the
repair-quic-metrics
branch
from
eaa5000 to
6470d3a
Compare
lijunwangs
reviewed
Oct 24, 2023
core/src/repair/quic_endpoint.rs
Outdated
| if let Err(err) = send_request(endpoint, connection, request).await { | ||
| error!("send_request: {err:?}") | ||
| debug!("send_request: {err:?}"); |
There was a problem hiding this comment.
Can we output the destination address? That will be useful when examining the logs.
core/src/repair/quic_endpoint.rs
Outdated
|
|
||
| async fn report_metrics_task(name: &'static str, stats: Arc<RepairQuicStats>) { | ||
| loop { | ||
| tokio::time::sleep(Duration::from_secs(2)).await; |
There was a problem hiding this comment.
Can we define the "2" as a constant on the top?
behzadnouri
force-pushed
the
repair-quic-metrics
branch
from
6470d3a to
580f0a6
Compare
lijunwangs
approved these changes
Oct 25, 2023
mergify bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
(cherry picked from commit e555a61)
anwayde
pushed a commit
to firedancer-io/solana
that referenced
this pull request
Nov 16, 2023
…33818) (solana-labs#33868) adds metrics to repair QUIC endpoint (solana-labs#33818) (cherry picked from commit e555a61) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
anwayde
pushed a commit
to firedancer-io/solana
that referenced
this pull request
Nov 16, 2023
…33818) (solana-labs#33868) adds metrics to repair QUIC endpoint (solana-labs#33818) (cherry picked from commit e555a61) Co-authored-by: behzad nouri <behzadnouri@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
monitor repair QUIC endpoint
Summary of Changes
added metrics.