revert programify feature gate #33897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CriesofCarrots
approved these changes
Oct 27, 2023
Codecov Report
@@ Coverage Diff @@
## master #33897 +/- ##
========================================
Coverage 81.9% 81.9%
========================================
Files 811 809 -2
Lines 218163 217957 -206
========================================
- Hits 178722 178586 -136
+ Misses 39441 39371 -70 |
mergify bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
(cherry picked from commit ecd674b)
buffalojoec
pushed a commit
that referenced
this pull request
Oct 27, 2023
anwayde
pushed a commit
to firedancer-io/solana
that referenced
this pull request
Nov 16, 2023
…solana-labs#33905) revert programify feature gate (solana-labs#33897) (cherry picked from commit ecd674b) Co-authored-by: Joe C <joe.caulfield@solana.com>
anwayde
pushed a commit
to firedancer-io/solana
that referenced
this pull request
Nov 16, 2023
…solana-labs#33905) revert programify feature gate (solana-labs#33897) (cherry picked from commit ecd674b) Co-authored-by: Joe C <joe.caulfield@solana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The changes required to replace the empty account at
Feature111111111111111111111111111111111111were already merged into master without any SIMD.It's been decided that we should collectively discuss the approach over an official SIMD, which can be found here:
solana-foundation/solana-improvement-documents#77
Since this SIMD process is ongoing, these changes should be reverted.
Summary of Changes
Revert the changes for the feature "programify feature gate program".
Note: The no-op program and feature keypair remain unchanged.