Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: ancient shrink on its own cadence (backport of #33712) #34060

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 14, 2023

This is an automatic backport of pull request #33712 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #34060 (1882362) into v1.17 (353aa64) will decrease coverage by 0.1%.
The diff coverage is 0.0%.

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.17   #34060     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         803      803             
  Lines      217915   217920      +5     
=========================================
- Hits       178391   178360     -31     
- Misses      39524    39560     +36     

@jeffwashington
Copy link
Contributor

This change is minor in effect on normal validators. When a validator skips rewrites, this is a necessary and valuable change. We expect to backport a cli change to allow a validator to skip rewrites. This allows validators to opt-in testing skipping rewrites for up to months. Having this change in 1.17 adds a whole release cycle of testing.
Ancient append vec code is a no-op if we are doing rewrites (which is default). So, this change will have no effect on normal validators or rpc nodes.

Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@jeffwashington jeffwashington merged commit 61caae6 into v1.17 Nov 17, 2023
31 checks passed
@jeffwashington jeffwashington deleted the mergify/bp/v1.17/pr-33712 branch November 17, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants