Uses Display in TieredStorageFile::new_readonly() panic message #34148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34148 +/- ##
=======================================
Coverage 81.9% 81.9%
=======================================
Files 818 818
Lines 219945 219945
=======================================
+ Hits 180199 180202 +3
+ Misses 39746 39743 -3 |
yhchiang-sol
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The panic message is user facing, and
Displayshould be used instead ofDebugwhen possible. This is not the case inTieredStorageFile::new_readonly().Summary of Changes
Use Display instead of Debug