[zk-token-sdk] Restrict range proof generator length and prevent 0-bit range proof #34166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34166 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 819 819
Lines 220122 220172 +50
=========================================
+ Hits 180386 180394 +8
- Misses 39736 39778 +42 |
samkim-crypto
added
v1.17
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
joncinque
approved these changes
Nov 20, 2023
samkim-crypto
added a commit
that referenced
this pull request
Nov 21, 2023
…nt 0-bit range proof (backport of #34166) (#34183) * [zk-token-sdk] Restrict range proof generator length and prevent 0-bit range proof (#34166) * limit range proof generator length * forbid 0-bit range proof verification (cherry picked from commit 0e6dd54) # Conflicts: # zk-token-sdk/src/range_proof/errors.rs # zk-token-sdk/src/range_proof/generators.rs # zk-token-sdk/src/range_proof/mod.rs * resolve conflict --------- Co-authored-by: samkim-crypto <skim13@cs.stanford.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the input to the range proof generator become very large, then this could lead to expected behavior (#33509).
Summary of Changes
Added a cap of
2^32, which should be plenty for all practical use cases.Fixes #