cleanup feature code after mainnet-beta activation #34208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34208 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 819 819
Lines 220894 220835 -59
=======================================
+ Hits 180753 180770 +17
+ Misses 40141 40065 -76 |
github-actions
bot
added
stale
apfitzge
reviewed
Dec 13, 2023
apfitzge
reviewed
Dec 13, 2023
apfitzge
requested changes
Dec 13, 2023
tao-stones
force-pushed
the
cleanup-feature-30366
branch
from
5288501 to
9d607cb
Compare
tao-stones
commented
Dec 15, 2023
| @@ -69,11 +69,8 @@ impl From<ComputeBudgetLimits> for FeeBudgetLimits { | |||
| /// are retrieved and returned, | |||
| pub fn process_compute_budget_instructions<'a>( | |||
| instructions: impl Iterator<Item = (&'a Pubkey, &'a CompiledInstruction)>, | |||
| feature_set: &FeatureSet, | |||
| _feature_set: &FeatureSet, | |||
There was a problem hiding this comment.
Will remove this parameter (7f63704) in a follow up PR, keep this PR feature cleanup only
apfitzge
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
feature
G6vbf1UBok8MWb8m25ex86aoQHeKTzDKzuZADHkShqm6add compute budget instruction for setting account data size per transaction #30366 activated everywhere.Summary of Changes
Fixes #