ci: add macos clippy test

[yihau]

Problem

we may accidentally merge some code that can break the macOS/Windows build

Summary of Changes

run clippy for macos.

(I would like to have Windows as well but it takes me too much time to fix 😢 so let's ship macos first)

[t-nelson]

thanks! looking pretty good. is this a problem?

also i think @CriesofCarrots mentioned that there's a bench that still fails macos clippy, but i don't see it raised here. not sure if it's been fixed or we aren't running against benches?

[yihau]

is this a problem?

where did you get this one 🤔 this is mine from here

screenshot

---

also i think CriesofCarrots mentioned that there's a bench that still fails macos clippy, but i don't see it raised here. not sure if it's been fixed or we aren't running against benches?

weird. I don't see any complains from this pipeline. let's wait for her insight!

[t-nelson]

where did you get this one 🤔 this is mine from here

weird. looks fine on this run. not sure how to dig through historical ones, but it showed an error when i first reviewd

[CriesofCarrots]

That bench that fails clippy on my machine is doing so because it calls jit_compile(), which is only available for x86_64. I'm on silicon and do not have rosetta installed, whereas the CI runner is intel.
I think we can move forward with this PR for now, but it might be nice to add an arm64 runner in the future.
Meanwhile, I'll PR tagging that bench as x86_64-only. (edit) #34282

[yihau]

@CriesofCarrots sorry for the force push. I didn't notice you already have a PR for tagging the bench test. just removed mine.

[CriesofCarrots]

Hey @yihau , the macos clippy job didn't run on this PR to v1.16, and hence automerge did not work.
I think we need to backport this to fix automerge for stable and beta?

[yihau]

yeah! we should have it for v1.16 and v1.17! thank you for brining this up!

[mergify]

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

[mergify]

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.