-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
solana-cli: format strings #34288
solana-cli: format strings #34288
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34288 +/- ##
=========================================
- Coverage 81.9% 81.9% -0.1%
=========================================
Files 819 819
Lines 219969 220027 +58
=========================================
- Hits 180326 180318 -8
- Misses 39643 39709 +66 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits
263a1cb
to
f0954b9
Compare
Sorry @steviez , I squashed the nit fixes into their relevant file-commits before I realized that would make it hard to re-review 😞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I squashed the nit fixes into their relevant file-commits before I realized that would make it hard to re-review
No worries, luckily not every file was touched and I had bene using the feature of marking files as viewed. I think I found a few more that we might as well grab
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This PR is spun out from #34274
Problem
Long string literals can cause rustfmt to fail, which results in rustfmt failing to format entire functions. There are many instances of this in the solana-cli.
Summary of Changes
Format and wrap strings to allow rustfmt to work again.
This PR was initiated by adding
format_strings = true
to the workspace rustfmt.toml. In general, this did a nice job.However, I chose to manually preserve or improve some of the original strings where the formatting seemed to break readability. (It is just my own personal preference that
[default: ..]
blocks not be broken across multiple lines.)If we impose
format_strings
on the workspace in the future, these strings will be "wrong" and need fixing.