patches slots_per_epoch vs last_slot ordering in shred_fetch_stage

[behzadnouri]

Problem

Orders are wrong and assigned wrong values.

Summary of Changes

Fixed ordering.

[mergify]

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

[mergify]

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

[codecov]

Codecov Report

Merging #34338 (af80933) into master (fa25176) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #34338     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         819      819             
  Lines      220422   220422             
=========================================
- Hits       180673   180672      -1     
- Misses      39749    39750      +1     

[AshwinSekar]

it seems we were getting by before because we set these correctly after DEFAULT_MS_PER_SLOT later in the loop?

[behzadnouri]

it seems we were getting by before because we set these correctly after DEFAULT_MS_PER_SLOT later in the loop?

yeah, i guess so

[steviez]

it seems we were getting by before because we set these correctly after DEFAULT_MS_PER_SLOT later in the loop?

yeah, i guess so

Late to the party, but agreed with Behzad; the initial values were bad but after 400ms they would be corrected. Good cleanup anyways and thanks for catching this!