Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: adds feature gated code to drop legacy shreds (backport of #34328) #34346

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 6, 2023

This is an automatic backport of pull request #34328 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@behzadnouri behzadnouri added the automerge Merge this Pull Request automatically once CI passes label Dec 6, 2023
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Dec 6, 2023
Copy link
Contributor Author

mergify bot commented Dec 6, 2023

automerge label removed due to a CI failure

Copy link

codecov bot commented Dec 6, 2023

Codecov Report

Merging #34346 (5854428) into v1.17 (311e986) will decrease coverage by 0.1%.
Report is 1 commits behind head on v1.17.
The diff coverage is 34.8%.

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.17   #34346     +/-   ##
=========================================
- Coverage    81.8%    81.8%   -0.1%     
=========================================
  Files         803      803             
  Lines      218110   218152     +42     
=========================================
- Hits       178570   178548     -22     
- Misses      39540    39604     +64     

@behzadnouri behzadnouri added the automerge Merge this Pull Request automatically once CI passes label Dec 7, 2023
Copy link
Contributor

@AshwinSekar AshwinSekar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@behzadnouri behzadnouri merged commit fe8f77e into v1.17 Dec 7, 2023
32 checks passed
@behzadnouri behzadnouri deleted the mergify/bp/v1.17/pr-34328 branch December 7, 2023 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants