Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment sysvar and builtin lists as deprecated and remove new keys #34365

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

jstarry
Copy link
Member

@jstarry jstarry commented Dec 8, 2023

Problem

Sysvar and builtin key lists shouldn't be exposed in the public API

Summary of Changes

  • Add comment saying that the lists will be deprecated and shouldn't be modified
  • Remove recently added sysvar keys from the sysvar list
  • Remove overly restrictive sysvar list inclusion test

Fixes #

@jstarry jstarry added the v1.17 PRs that should be backported to v1.17 label Dec 8, 2023
@jstarry jstarry requested a review from t-nelson December 8, 2023 03:35
Copy link
Contributor

mergify bot commented Dec 8, 2023

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

Merging #34365 (4694e77) into master (8c6239c) will increase coverage by 0.0%.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34365   +/-   ##
=======================================
  Coverage    82.0%    82.0%           
=======================================
  Files         819      819           
  Lines      220598   220592    -6     
=======================================
+ Hits       180898   180909   +11     
+ Misses      39700    39683   -17     

Copy link
Contributor

@willhickey willhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jstarry jstarry merged commit 79739e1 into solana-labs:master Dec 8, 2023
45 checks passed
@jstarry jstarry deleted the fix/deprecation-comment branch December 8, 2023 17:17
mergify bot pushed a commit that referenced this pull request Dec 8, 2023
willhickey pushed a commit that referenced this pull request Dec 8, 2023
…keys (backport of #34365) (#34369)

Comment sysvar and builtin lists as deprecated and remove new keys (#34365)

(cherry picked from commit 79739e1)

Co-authored-by: Justin Starry <justin.starry@icloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.17 PRs that should be backported to v1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants