bank: Add errored compute units during simulation #34450
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Transaction simulations only sum up the compute units of successful instructions, meaning that the compute units used on the errored instruction are lost. This creates a divergence between execution and simulation.
Summary of Changes
This one was pretty simple! Simply include the errored units to the reported units consumed. We could also read it out of the
execution_results
and avoid using thetimings
, but it seemed fine to stick with thetimings
since they gave the correct result.Fixes #34445