Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unused imports #34467

Merged
merged 1 commit into from
Dec 14, 2023
Merged

remove unused imports #34467

merged 1 commit into from
Dec 14, 2023

Conversation

yihau
Copy link
Member

@yihau yihau commented Dec 14, 2023

Problem

Screenshot 2023-12-15 at 01 51 52

Summary of Changes

remove the unused imports.

@yihau yihau requested a review from CriesofCarrots December 14, 2023 17:57
CriesofCarrots
CriesofCarrots approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why CI didn't catch this on the PR?
#34359
cc @taozhu-chicago

@yihau
Copy link
Member Author

yihau commented Dec 14, 2023 •
edited
Loading

it passed check. I'm going to merge it on red!

@CriesofCarrots I'm guessing Tao's branch doesn't really rebase the latest master 🤔 he had some changes in the same file these days.

(maybe a before merge test can save us here. iirc the merge queue can do it!)

@yihau yihau merged commit 5b1aa63 into solana-labs:master Dec 14, 2023
25 of 30 checks passed
@yihau yihau deleted the fix-ci branch December 14, 2023 18:12
@tao-stones
Copy link
Contributor

it passed check. I'm going to merge it on red!

@CriesofCarrots I'm guessing Tao's branch doesn't really rebase the latest master 🤔 he had some changes in the same file these days.

(maybe a before merge test can save us here. iirc the merge queue can do it!)

I think I rebased master before commit, but I could be wrong. Maybe the PR waited long enough time between CI green and approval/merge?

@willhickey willhickey mentioned this pull request Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CriesofCarrots CriesofCarrots CriesofCarrots approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihau @tao-stones @CriesofCarrots