[zk-token-sdk] Fix range proof transcript seed typo #34468
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
samkim-crypto
added
v1.17
|
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
CriesofCarrots
approved these changes
Dec 14, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34468 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 819 819
Lines 220919 220919
=======================================
+ Hits 180853 180865 +12
+ Misses 40066 40054 -12 |
mergify bot
pushed a commit
that referenced
this pull request
Dec 14, 2023
fix range proof transcript seed typo (cherry picked from commit aaccbdd)
samkim-crypto
added a commit
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As pointed out in #34459 (review), there is a typo when calculating the hash of the merlin transcript in the range proof calculation. This should be fixed, but it does break compatibility with 1.17 and hence, must be backported to 1.17.
Summary of Changes
This PR is a one-line fix for the typo that should be backported to 1.17.
Note: The zk-token-proof program is not yet activated on any of the clusters.
Fixes #