-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rekey stake limit feature #34503
rekey stake limit feature #34503
Conversation
512b165
to
2ba7ff5
Compare
Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis. |
Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. |
This feature has been implemented since v1.16. And this pr should be backported to 1.16 and 1.17. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #34503 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 820 820
Lines 220790 220790
=======================================
+ Hits 180679 180709 +30
+ Misses 40111 40081 -30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@t-nelson Can you double check this one too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: HaoranYi <haoran.yi@solana.com> (cherry picked from commit 1ac017c)
Co-authored-by: HaoranYi <haoran.yi@solana.com> (cherry picked from commit 1ac017c)
Co-authored-by: HaoranYi <haoran.yi@solana.com> (cherry picked from commit 1ac017c)
Problem
I lost the key for
stake_minimum_delegation_for_rewards
when I migrated from gcp boxes.Summary of Changes
rekey stake_minimum_delegation_for_rewards feature
Fixes #
Feature Gate Issue: #29622