Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rekey stake limit feature #34503

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

HaoranYi
Copy link
Contributor

@HaoranYi HaoranYi commented Dec 18, 2023

Problem

I lost the key for stake_minimum_delegation_for_rewards when I migrated from gcp boxes.

Summary of Changes

rekey stake_minimum_delegation_for_rewards feature

Fixes #

Feature Gate Issue: #29622

@HaoranYi HaoranYi force-pushed the 2023_12_18_rekey_stake_limit branch from 512b165 to 2ba7ff5 Compare December 18, 2023 14:51
@HaoranYi HaoranYi added the v1.17 PRs that should be backported to v1.17 label Dec 18, 2023
Copy link
Contributor

mergify bot commented Dec 18, 2023

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@HaoranYi HaoranYi added the v1.16 PRs that should be backported to v1.16 label Dec 18, 2023
Copy link
Contributor

mergify bot commented Dec 18, 2023

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

@HaoranYi
Copy link
Contributor Author

HaoranYi commented Dec 18, 2023

This feature has been implemented since v1.16. And this pr should be backported to 1.16 and 1.17.

@brooksprumo brooksprumo added the feature-gate Pull Request adds or modifies a runtime feature gate label Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #34503 (2ba7ff5) into master (4181ea4) will increase coverage by 0.0%.
Report is 1 commits behind head on master.
The diff coverage is 100.0%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34503   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         820      820           
  Lines      220790   220790           
=======================================
+ Hits       180679   180709   +30     
+ Misses      40111    40081   -30     

@brooksprumo brooksprumo requested a review from t-nelson December 18, 2023 16:33
Copy link
Contributor

@brooksprumo brooksprumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@t-nelson Can you double check this one too?

Copy link
Contributor

@willhickey willhickey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending follow up:

Update Issue #29622

  • Key
  • Min versions (v1.16.26 and v1.17.13)

@HaoranYi HaoranYi merged commit 1ac017c into solana-labs:master Dec 18, 2023
47 checks passed
mergify bot pushed a commit that referenced this pull request Dec 18, 2023
Co-authored-by: HaoranYi <haoran.yi@solana.com>
(cherry picked from commit 1ac017c)
mergify bot pushed a commit that referenced this pull request Dec 18, 2023
Co-authored-by: HaoranYi <haoran.yi@solana.com>
(cherry picked from commit 1ac017c)
willhickey pushed a commit that referenced this pull request Dec 21, 2023
Co-authored-by: HaoranYi <haoran.yi@solana.com>
(cherry picked from commit 1ac017c)
HaoranYi added a commit that referenced this pull request Dec 21, 2023
rekey stake limit feature (#34503)

Co-authored-by: HaoranYi <haoran.yi@solana.com>
(cherry picked from commit 1ac017c)

Co-authored-by: HaoranYi <haoran.yi@gmail.com>
HaoranYi added a commit that referenced this pull request Dec 22, 2023
rekey stake limit feature (#34503)

Co-authored-by: HaoranYi <haoran.yi@solana.com>
(cherry picked from commit 1ac017c)

Co-authored-by: HaoranYi <haoran.yi@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-gate Pull Request adds or modifies a runtime feature gate v1.16 PRs that should be backported to v1.16 v1.17 PRs that should be backported to v1.17
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants