Removes unused Bank::accounts_data_size_limit() #34700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
cap-accounts-data-len/remove/limit
branch
from
5c6d4c1 to
918d05b
Compare
brooksprumo
force-pushed
the
cap-accounts-data-len/remove/limit
branch
from
918d05b to
5ad3610
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #34700 +/- ##
=======================================
Coverage 81.8% 81.8%
=======================================
Files 824 824
Lines 222693 222691 -2
=======================================
+ Hits 182236 182285 +49
+ Misses 40457 40406 -51 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bank::accounts_data_size_limit()no longer has any callers. And we'd like to removeAccountsDataMeter. So remove this function, and then it'll be clear there are no other users of AccountsDataMeter.Summary of Changes
Remove Bank::accounts_data_size_limit()