Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds newline to fastboot's CLI help #34712

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Jan 9, 2024

Problem

I noticed the help text for fastboot (--use-snapshot-archives-at-startup) was missing a newline for "Specifying when-newest". Here's the current help text. I've added a (X) for the missing newline.

    --use-snapshot-archives-at-startup <use_snapshot_archives_at_startup>
            At startup, when should snapshot archives be extracted versus using what is already on disk? 
            Specifying "always" will always startup by extracting snapshot archives and disregard any snapshot-related
            state already on disk. Note that starting up from snapshot archives will incur the runtime costs associated
            with extracting the archives and rebuilding the local state. 
            Specifying "never" will never startup from snapshot archives and will only use snapshot-related state
            already on disk. If there is no state already on disk, startup will fail. Note, this will use the latest
            state available, which may be newer than the latest snapshot archive. (X) Specifying "when-newest" will use
            snapshot-related state already on disk unless there are snapshot archives newer than it. This can happen if
            a new snapshot archive is downloaded while the node is stopped. [default: always]  [possible values: always,
            never, when-newest]

Summary of Changes

Add the missing newline.

@brooksprumo brooksprumo self-assigned this Jan 9, 2024
@brooksprumo brooksprumo added the v1.17 PRs that should be backported to v1.17 label Jan 9, 2024
Copy link
Contributor

mergify bot commented Jan 9, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

@brooksprumo brooksprumo marked this pull request as ready for review January 9, 2024 17:18
@brooksprumo brooksprumo requested a review from apfitzge January 9, 2024 17:18
@brooksprumo brooksprumo added the automerge Merge this Pull Request automatically once CI passes label Jan 9, 2024
@mergify mergify bot removed the automerge Merge this Pull Request automatically once CI passes label Jan 9, 2024
Copy link
Contributor

mergify bot commented Jan 9, 2024

automerge label removed due to a CI failure

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (74fde2d) 81.8% compared to head (3061398) 81.8%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34712   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         824      824           
  Lines      222719   222719           
=======================================
+ Hits       182285   182305   +20     
+ Misses      40434    40414   -20     

@brooksprumo brooksprumo merged commit abe699b into solana-labs:master Jan 9, 2024
53 of 57 checks passed
@brooksprumo brooksprumo deleted the fastboot/cli/help branch January 9, 2024 20:28
mergify bot pushed a commit that referenced this pull request Jan 9, 2024
brooksprumo added a commit that referenced this pull request Jan 10, 2024
Adds newline to fastboot's CLI help (#34712)

(cherry picked from commit abe699b)

Co-authored-by: Brooks <brooks@solana.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.17 PRs that should be backported to v1.17
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants