Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes AccountsDataMeter #34727

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Jan 10, 2024

Problem

The AccountsDataMeter is not used by anything.

Summary of Changes

Remove it.

@brooksprumo brooksprumo added the work in progress This isn't quite right yet label Jan 10, 2024
@brooksprumo brooksprumo self-assigned this Jan 10, 2024
@brooksprumo brooksprumo force-pushed the accounts-data-size/accounts-data-meter/remove branch from 22ed685 to 1529fee Compare January 10, 2024 17:37
@brooksprumo brooksprumo removed the work in progress This isn't quite right yet label Jan 10, 2024
@brooksprumo brooksprumo marked this pull request as ready for review January 10, 2024 18:34
@brooksprumo brooksprumo requested a review from Lichtso January 10, 2024 18:35
Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (88f8d11) 81.8% compared to head (1529fee) 81.8%.
Report is 6 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34727   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         824      823    -1     
  Lines      222730   222677   -53     
=======================================
- Hits       182293   182256   -37     
+ Misses      40437    40421   -16     

@brooksprumo brooksprumo merged commit fb35552 into solana-labs:master Jan 10, 2024
36 checks passed
@brooksprumo brooksprumo deleted the accounts-data-size/accounts-data-meter/remove branch January 10, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants