Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: Use program length for deployments instead of 2x length #34730

Merged
merged 5 commits into from
Jan 10, 2024

Conversation

joncinque
Copy link
Contributor

Problem

The default behavior for program deployments uses 2x the length of the deployed program. This behavior accommodated larger program deployments over time, but requires a greater upfront cost. With solana program extend, however, there's no need to lock up more SOL than necessary for a program.

Summary of Changes

Use the program length when deploying instead of 2x, and update the documentation to reflect that change, including how to extend a program.

There might be some overlap of changes by including the extend documentation, so let me know if you prefer that in a separate PR!

Fixes #

@pgarg66
Copy link
Contributor

pgarg66 commented Jan 10, 2024

Looks good to me! Giving time to @CriesofCarrots to review it before approving it.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c5d51ac) 81.8% compared to head (ff6db66) 81.8%.
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #34730   +/-   ##
=======================================
  Coverage    81.8%    81.8%           
=======================================
  Files         824      824           
  Lines      222725   222723    -2     
=======================================
+ Hits       182317   182356   +39     
+ Misses      40408    40367   -41     

Copy link
Contributor

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ nit in changelog text

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Tyera <teulberg@gmail.com>
@joncinque joncinque added the automerge Merge this Pull Request automatically once CI passes label Jan 10, 2024
@mergify mergify bot merged commit 5cb30cf into solana-labs:master Jan 10, 2024
36 checks passed
@joncinque joncinque deleted the dep2 branch January 10, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants