Bring up to date the concurrent accounts benches #34815
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Accounts Index has a type to represent reading an entry that is internally self referencing (
ReadAccountMapEntry
). In #34786, this type has been identified as contributing significantly to memory management overhead. That issue points to #12787 as the source of the type, and this pull-request mentions (and adds code for) benches that justify the changes.However, running these benches fails because it violates assertions in accounts db:
This is because we now always use a write cache in AccountsDb, and these benches were written before the write cache was required.
I'd like to use these benches while working on #34786, so these benches need to be updated to run again.
Summary of Changes
Update
store_accounts_with_possible_contention()
such that it stores accounts using the write cache.