Replaces ReadAccountMapEntry in accounts index #35239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brooksprumo
force-pushed
the
self-ref/3/index/1
branch
from
6213a59 to
6013915
Compare
brooksprumo
changed the title
brooksprumo
commented
Feb 19, 2024
|
|
||
| let entry = if *lock { | ||
| index | ||
| .get_account_read_entry_with_lock(&key, read_lock.as_ref().unwrap()) |
There was a problem hiding this comment.
This is the last use of get_account_read_entry_with_lock(). It will be removed in #35240.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #34786 for background.
We want to limit the use of
ReadAccountMapEntry, from AccountsIndex, everywhere. Ultimately removing it once there are no more uses.Tests in Accounts Index use
ReadAccountMapEntryviaget_account_read_entry()to assert expectations of slot lists and ref counts. They can be rewritten to not needReadAccountMapEntrythough.Summary of Changes
Replaces get_account_read_entry() in accounts index