-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes ReadAccountMapEntry #35351
Removes ReadAccountMapEntry #35351
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #35351 +/- ##
=======================================
Coverage 81.7% 81.7%
=======================================
Files 834 834
Lines 224299 224310 +11
=======================================
+ Hits 183361 183376 +15
+ Misses 40938 40934 -4 |
90b45ad
to
d02488b
Compare
what about cargo.toml? |
Removing the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay!
Let's have a party to celebrate 🥳 |
Problem
See #34786 for background.
We want to limit the use of
ReadAccountMapEntry
, from AccountsIndex, everywhere. Ultimately removing it once there are no more uses.And now, there are no more uses!
Summary of Changes
Each is its own commit, to make it easier to step through:
get()
AccountIndexGetResult
ReadAccountMapEntry
Fixes #34786