Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes ReadAccountMapEntry #35351

Conversation

brooksprumo
Copy link
Contributor

@brooksprumo brooksprumo commented Feb 28, 2024

Problem

See #34786 for background.

We want to limit the use of ReadAccountMapEntry, from AccountsIndex, everywhere. Ultimately removing it once there are no more uses.

And now, there are no more uses!

Summary of Changes

Each is its own commit, to make it easier to step through:

  • Remove get()
  • Remove AccountIndexGetResult
  • Remove ReadAccountMapEntry

Fixes #34786

@brooksprumo brooksprumo added the work in progress This isn't quite right yet label Feb 28, 2024
@brooksprumo brooksprumo self-assigned this Feb 28, 2024
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.7%. Comparing base (6ee3bb9) to head (90b45ad).
Report is 6 commits behind head on master.

❗ Current head 90b45ad differs from pull request most recent head d02488b. Consider uploading reports for the commit d02488b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #35351   +/-   ##
=======================================
  Coverage    81.7%    81.7%           
=======================================
  Files         834      834           
  Lines      224299   224310   +11     
=======================================
+ Hits       183361   183376   +15     
+ Misses      40938    40934    -4     

@brooksprumo brooksprumo force-pushed the self-ref/remove-read-account-map-entry branch from 90b45ad to d02488b Compare February 28, 2024 19:39
@brooksprumo brooksprumo removed the work in progress This isn't quite right yet label Feb 28, 2024
@brooksprumo brooksprumo marked this pull request as ready for review February 28, 2024 19:40
@jeffwashington
Copy link
Contributor

what about cargo.toml?

@brooksprumo
Copy link
Contributor Author

what about cargo.toml?

Removing the ouroboros dependency will be done in #35355.

Copy link
Contributor

@jeffwashington jeffwashington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay!

@HaoranYi
Copy link
Contributor

Let's have a party to celebrate 🥳

@brooksprumo brooksprumo merged commit 140c21f into solana-labs:master Feb 28, 2024
36 checks passed
@brooksprumo brooksprumo deleted the self-ref/remove-read-account-map-entry branch February 28, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self reference in ReadAccountMapEntry
3 participants