Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate coverage with Rust nightly #378

Merged
merged 4 commits into from
Jun 24, 2018

Conversation

garious
Copy link
Contributor

@garious garious commented Jun 18, 2018

Fixes #177

Thanks @marco-c!

@garious garious requested a review from mvines June 18, 2018 23:48
@mvines
Copy link
Member

mvines commented Jun 19, 2018

@garious garious force-pushed the add-cargo-cov branch 2 times, most recently from c610a47 to ec0edc6 Compare June 20, 2018 18:42
@garious
Copy link
Contributor Author

garious commented Jun 21, 2018

Hey @mvines, I can't seem to reproduce the nightly build within docker on macos. It gets stuck compiling pnet_transport when installing cargo-cov.

In CI, this build fails because gcov fails, which is called by the codecov bash script. To fix, we probably need a gcov version that matches Rust's coverage instrumentation. The cargo-cov repo suggests installing libclang-common-6.0-dev on Ubuntu. I assume that'll install llvm.gcov. We'd need to tell the codecov script to use that gcov_exe instead of gcov. Ideally, Rust would deploy llvm.gcov. There's an open ticket to add some LLVM tools, but that list doesn't currently include llvm.gcov: rust-lang/rust#49584 @marco-c, any related info we should be aware of?

@mvines mvines self-assigned this Jun 21, 2018
@marco-c
Copy link

marco-c commented Jun 21, 2018

The problem is that the codecov tool is trying to use gcov, but gcov is the gcc tool which parses a different version of the gcno/gcda format.
It should use llvm-cov.
A possible solution is to generate the codecov output yourself (e.g. using grcov) and upload it yourself. Perhaps we should add this to cargo-cov.

@marco-c
Copy link

marco-c commented Jun 21, 2018

Or you could try this "hack": codecov/codecov-bash#55 (comment) (with latest llvm-cov, not llvm-cov-3.8).

@garious garious force-pushed the add-cargo-cov branch 3 times, most recently from 9b5061c to 94b1c43 Compare June 24, 2018 17:25
@codecov
Copy link

codecov bot commented Jun 24, 2018

Codecov Report

Merging #378 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #378   +/-   ##
=======================================
  Coverage   91.34%   91.34%           
=======================================
  Files          36       36           
  Lines        3583     3583           
=======================================
  Hits         3273     3273           
  Misses        310      310

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2accd1...8ae26ff. Read the comment docs.

garious added 2 commits June 24, 2018 11:34
@marco-c called this a hack, but since grcov isn't working
out-of-the-box (panics on call to gcov), we'll take a stab at using
llvm-cov.
@marco-c
Copy link

marco-c commented Jun 24, 2018

(to use grcov with Rust-generated files you need to pass the --llvm option)

@garious
Copy link
Contributor Author

garious commented Jun 24, 2018

Thanks @marco-c, I confirmed that adding the --llvm option gets grcov to run out-of-the-box on macOS.

@garious garious merged commit 6fc601f into solana-labs:master Jun 24, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
)

Bumps [@babel/cli](https://github.com/babel/babel/tree/HEAD/packages/babel-cli) from 7.10.5 to 7.11.5.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.11.5/packages/babel-cli)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants