add a clock to validator windows (part 3 of #309) #448

rob-solana · 2018-06-25T20:03:59Z

count entries processed by Bank
initialize windows with initial height of Entries

* count entries processed by Bank * initialize windows with initial height of Entries

garious

Looks like this could use a test. I'd think that you need to pass entry_count() to the leader's default_window() for the validator to see the same count as the leader.

sakridge

lgtm

garious · 2018-06-25T23:00:49Z

src/bank.rs

            if !entry.transactions.is_empty() {
                for result in self.process_transactions(entry.transactions) {
                    result?;
                }
            }
            self.register_entry_id(&entry.id);
        }
-        Ok(())
+        Ok(self.entry_count())


@rob-solana, It's strange to both return this value and set a state variable. You're offering two ways to get the same information. I'd recommend getting rid of the state variable.

the return value is a nice info thingie. the state variable is the real useful one: it's pulled out later for server/streamer/window construction

…olana-labs#448)" This reverts commit 1919ec2.

* Remove pack's dependency on TokenError * nudge

Backport clone derivation (416) (solana-labs#418) backports solana-labs#430: update jito-programs (solana-labs#432) Backport solana-labs#446 to v1.17 (solana-labs#448) [JIT-1661] Faster Autosnapshot (solana-labs#445) v1.17: Backport solana-labs#449 (solana-labs#451) backports solana-labs#419: add upsert to accountoverrides (solana-labs#421) backport 428 runtime-plugin (solana-labs#458) [JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499) Backport solana-labs#500 to v1.17 (solana-labs#507) Backport solana-labs#520: add priority fees to mev claim (solana-labs#525)

Backport clone derivation (416) (solana-labs#418) backports solana-labs#430: update jito-programs (solana-labs#432) Backport solana-labs#446 to v1.17 (solana-labs#448) [JIT-1661] Faster Autosnapshot (solana-labs#445) v1.17: Backport solana-labs#449 (solana-labs#451) backports solana-labs#419: add upsert to accountoverrides (solana-labs#421) backport 428 runtime-plugin (solana-labs#458) [JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499) Backport solana-labs#500 to v1.17 (solana-labs#507) Backport solana-labs#520: add priority fees to mev claim (solana-labs#525) Faster MEV tip claiming (v1.17) (solana-labs#568) Backport Release Fixes (solana-labs#586)

Backport clone derivation (416) (solana-labs#418) backports solana-labs#430: update jito-programs (solana-labs#432) Backport solana-labs#446 to v1.17 (solana-labs#448) [JIT-1661] Faster Autosnapshot (solana-labs#445) v1.17: Backport solana-labs#449 (solana-labs#451) backports solana-labs#419: add upsert to accountoverrides (solana-labs#421) backport 428 runtime-plugin (solana-labs#458) [JIT-1713] Fix bundle's blockspace preallocation (Backport to 1.17) (solana-labs#499) Backport solana-labs#500 to v1.17 (solana-labs#507) Backport solana-labs#520: add priority fees to mev claim (solana-labs#525) Faster MEV tip claiming (v1.17) (solana-labs#568) Backport Release Fixes (solana-labs#586) Update release URLs for jito-solana (solana-labs#589) Backports solana-labs#595: correctly initialize account overrides (solana-labs#599) Fix: Ensure set contact info to UDP port instead of QUIC (solana-labs#601) Buffer bundles that exceed processing time and make the allowed processing time longer (solana-labs#609)

add a clock to validator windows (part 3 of solana-labs#309)

4f377dd

* count entries processed by Bank * initialize windows with initial height of Entries

rob-solana requested review from garious, aeyakovenko and sakridge June 25, 2018 20:04

garious approved these changes Jun 25, 2018

View reviewed changes

garious reviewed Jun 25, 2018

View reviewed changes

aeyakovenko approved these changes Jun 25, 2018

View reviewed changes

sakridge approved these changes Jun 25, 2018

View reviewed changes

aeyakovenko merged commit 1919ec2 into solana-labs:master Jun 25, 2018

garious reviewed Jun 25, 2018

View reviewed changes

rob-solana added the work in progress This isn't quite right yet label Jun 26, 2018

rob-solana deleted the initialize-windows-with-Entry-count branch June 26, 2018 00:14

mvines added a commit to mvines/solana that referenced this pull request Jun 26, 2018

Revert "add a clock to validator windows (part 3 of solana-labs#309) (s…

4efd462

…olana-labs#448)" This reverts commit 1919ec2.

mvines added a commit to mvines/solana that referenced this pull request Jun 26, 2018

Revert "add a clock to validator windows (part 3 of solana-labs#309) (s…

8a52a1c

…olana-labs#448)" This reverts commit 1919ec2.

rob-solana removed the work in progress This isn't quite right yet label Jun 26, 2018

rob-solana restored the initialize-windows-with-Entry-count branch June 26, 2018 20:42

rob-solana deleted the initialize-windows-with-Entry-count branch June 26, 2018 20:56

vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021

Remove pack's dependency on TokenError (solana-labs#448)

157936c

* Remove pack's dependency on TokenError * nudge

vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021

backport solana-labs#448 to v2

51dc1ae

Kashuhackerone mentioned this pull request Jun 20, 2023

[Snyk] Fix for 1 vulnerabilities Kashuhackerone/solana#60

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add a clock to validator windows (part 3 of #309) #448

add a clock to validator windows (part 3 of #309) #448

rob-solana commented Jun 25, 2018

garious left a comment •

edited

Loading

sakridge left a comment

garious Jun 25, 2018

rob-solana Jun 25, 2018

add a clock to validator windows (part 3 of #309) #448

add a clock to validator windows (part 3 of #309) #448

Conversation

rob-solana commented Jun 25, 2018

garious left a comment • edited Loading

Choose a reason for hiding this comment

sakridge left a comment

Choose a reason for hiding this comment

garious Jun 25, 2018

Choose a reason for hiding this comment

rob-solana Jun 25, 2018

Choose a reason for hiding this comment

garious left a comment •

edited

Loading