Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable transaction fees for multinode-demo/ and net/ #4527

Merged
merged 2 commits into from
Jun 4, 2019

Conversation

mvines
Copy link
Member

@mvines mvines commented Jun 3, 2019

Attempt #2. The first commit in here is from #4525.

multinode-demo/ now differentiates between the lamports used for staking and lamports used for funding transactions. All nodes by default still get a stake of 42 but receive 424242 lamports in their identity account for funding transactions.

@mvines mvines requested a review from pgarg66 June 3, 2019 22:23
@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #4527 into master will increase coverage by <.1%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #4527     +/-   ##
========================================
+ Coverage    79.4%   79.4%   +<.1%     
========================================
  Files         181     181             
  Lines       32174   32187     +13     
========================================
+ Hits        25570   25585     +15     
+ Misses       6604    6602      -2

1 similar comment
@codecov
Copy link

codecov bot commented Jun 3, 2019

Codecov Report

Merging #4527 into master will increase coverage by <.1%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #4527     +/-   ##
========================================
+ Coverage    79.4%   79.4%   +<.1%     
========================================
  Files         181     181             
  Lines       32174   32187     +13     
========================================
+ Hits        25570   25585     +15     
+ Misses       6604    6602      -2

@mvines mvines added the blocked Unable to proceed label Jun 4, 2019
@mvines
Copy link
Member Author

mvines commented Jun 4, 2019

Depends-on: #4530

@mvines mvines removed the blocked Unable to proceed label Jun 4, 2019
@mvines mvines merged commit e336552 into solana-labs:master Jun 4, 2019
@mvines mvines deleted the fee branch June 4, 2019 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants