-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do Proof of History verification before appending entries to the bank #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: replicate_stage is still using `process_entries()` because changing it to `process_blocks()` causes the `test_replicate` test to fail.
rob-solana
reviewed
Jun 29, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
* init * instructions * instruction progress * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * wip * update * wip * update * wip * clippy * builds * builds * wip test * init testcargo fmt * update * wip stake instructions * wip * comment * update * update * update * init cli * Address review comments Co-authored-by: Jon Cinque <jon.cinque@gmail.com>
brooksprumo
pushed a commit
to brooksprumo/solana
that referenced
this pull request
Mar 29, 2024
* add TRIGGERED_BUILDKITE_TAG to the pipeline * publish a pre-release for the release id
t-nelson
pushed a commit
to t-nelson/solana
that referenced
this pull request
Apr 2, 2024
…na-labs#493) (solana-labs#498) ci: fix some issues for the release pipeline (solana-labs#493) * add TRIGGERED_BUILDKITE_TAG to the pipeline * publish a pre-release for the release id (cherry picked from commit b1e1799) Co-authored-by: Yihau Chen <a122092487@gmail.com>
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Apr 7, 2024
…na-labs#493) (solana-labs#499) ci: fix some issues for the release pipeline (solana-labs#493) * add TRIGGERED_BUILDKITE_TAG to the pipeline * publish a pre-release for the release id (cherry picked from commit b1e1799) Co-authored-by: Yihau Chen <a122092487@gmail.com>
HaoranYi
pushed a commit
to HaoranYi/solana
that referenced
this pull request
Apr 8, 2024
…na-labs#493) (solana-labs#498) ci: fix some issues for the release pipeline (solana-labs#493) * add TRIGGERED_BUILDKITE_TAG to the pipeline * publish a pre-release for the release id (cherry picked from commit b1e1799) Co-authored-by: Yihau Chen <a122092487@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: replicate_stage is still using
process_entries()
becausechanging it to
process_blocks()
causes thetest_replicate
test tofail.