Add libudev-dev to docker image to build remote-wallet #8149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpaul000
approved these changes
Feb 6, 2020
CriesofCarrots
added
the
automerge
Codecov Report
@@ Coverage Diff @@
## master #8149 +/- ##
========================================
+ Coverage 81.8% 81.8% +<.1%
========================================
Files 247 247
Lines 53617 53617
========================================
+ Hits 43890 43898 +8
+ Misses 9727 9719 -8 |
mergify bot
pushed a commit
that referenced
this pull request
Feb 6, 2020
automerge (cherry picked from commit b832a03) # Conflicts: # Cargo.lock
CriesofCarrots
added a commit
that referenced
this pull request
Feb 7, 2020
automerge (cherry picked from commit b832a03)
solana-grimes
pushed a commit
that referenced
this pull request
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The upcoming remote-wallet implementation uses hidapi to communicate with usb wallet devices on various platforms. On Linux, this depends on libudev, which ships with most ubuntu builds. However, to compile the remote-wallet binary, libudev-dev is also required.
Summary of Changes
Add libudev-dev to solanalabs rust docker images
Also, fixup Cargo.lock with changes that got reverted in crossed prs
Required for #8068