Fix recv_from allocating unnecessary memory #8187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #8187 +/- ##
======================================
Coverage 81.4% 81.4%
======================================
Files 252 252
Lines 54478 54497 +19
======================================
+ Hits 44354 44371 +17
- Misses 10124 10126 +2 |
aeyakovenko
approved these changes
Feb 10, 2020
|
@mvines, no it doesn't unfortunately :'(, although it probably makes the situation worse. This is a separate issue discovered while looking into that one. |
mergify bot
pushed a commit
that referenced
this pull request
Feb 10, 2020
(cherry picked from commit 0b263f8)
mergify bot
pushed a commit
that referenced
this pull request
Feb 10, 2020
(cherry picked from commit 0b263f8)
solana-grimes
pushed a commit
that referenced
this pull request
Feb 10, 2020
solana-grimes
pushed a commit
that referenced
this pull request
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
recv_from() can allocate more memory in the Packets buffer than it needs
Summary of Changes
Make sure recv_from() doesn't allocate more than
PACKETS_PER_BATCHnumber of packetsFixes #