forked from solana-labs/solana-program-library
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
donate to reserve function #194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nope-finance
force-pushed
the
donate_to_reserve
branch
from
September 23, 2024 08:14
3671819
to
5fe7501
Compare
nope-finance
force-pushed
the
donate_to_reserve
branch
from
September 23, 2024 08:49
5fe7501
to
f6c6ecb
Compare
0xripleys
reviewed
Oct 16, 2024
msg!("Reserve liquidity supply does not match the reserve liquidity supply provided"); | ||
return Err(LendingError::InvalidAccountInput.into()); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typically we also check this, but i don't think it's strictly necessary:
if &reserve.liquidity.supply_pubkey == source_liquidity_info.key {
msg!("Reserve liquidity supply cannot be used as the source liquidity provided");
return Err(LendingError::InvalidAccountInput.into());
}
0xripleys
reviewed
Oct 16, 2024
if lending_market_info.owner != program_id { | ||
msg!("Lending market provided is not owned by the lending program"); | ||
return Err(LendingError::InvalidAccountOwner.into()); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing reserve whitelist
nope-finance
force-pushed
the
donate_to_reserve
branch
2 times, most recently
from
October 16, 2024 20:31
869d856
to
d664321
Compare
nope-finance
force-pushed
the
donate_to_reserve
branch
from
October 18, 2024 06:16
d664321
to
973787d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.