fix: 🤔 missing border when sd-select has not enough space #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Vahid1919
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
Leave review to you @MartaPintoTeixeira |
|
@Vahid1919 pls add a screenshot test for this. |
Vahid1919
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
@karlbaumhauer Added a screenshot test |
|
Please check my comment in Chromatic |
karlbaumhauer
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Limited the height of the listbox using an interesting CSS variable I found in the wrapping sd-popup :)
--auto-size-available-height. Closes #1042.Definition of Reviewable: