Skip to content
This repository has been archived by the owner on Apr 13, 2022. It is now read-only.

Remove SPARQL on GET #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

RubenVerborgh
Copy link
Contributor

@RubenVerborgh RubenVerborgh commented Jul 24, 2019

  • it’s a bad idea for scalability, DOS, and other reasons
  • it’s not implementable the way it is written (subset not defined)
  • it’s not implemented or used anywhere as far as we know

I strongly favor removal over deprecation (#205).

@dmitrizagidulin
Copy link
Member

👍

@michielbdejong
Copy link
Contributor

Looks like two members of the query panel already agree on this so could be a quick decision :) cc @kjetilk @justinwb.

Copy link
Member

@acoburn acoburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
I agree that removal is preferred over deprecation.

@RubenVerborgh
Copy link
Contributor Author

RubenVerborgh commented Jul 24, 2019

@dmitrizagidulin Thanks, could you do that as a review, too? 🙂

@michielbdejong Not sure what part of process to follow here, given that this is not a normative section. We might or might not need a week for the public and approval by three editors; also unsure if I can merge. Assigning to you; feel free to unassign.

Copy link
Member

@dmitrizagidulin dmitrizagidulin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 to removing this section. (I remember that it's caused numerous confused questions from developers reading the spec, since it wasn't actually implemented.)

@kjetilk
Copy link
Member

kjetilk commented Jul 30, 2019

Actually, I am a bit conflicted, since I could see how it could be implemented easily, and I'm not sure very extensive edits are needed to the document at this point as we restart from scratch. It might just stay there for historical reasons. But OTOH, since it hasn't been implemented and has problems, it can be removed just fine too.

@RubenVerborgh
Copy link
Contributor Author

@kjetilk The issue is that, whatever is in solid-spec, will end up in vNext; the only option to not have a feature end up in vNext is to remove it from solid-spec. So my main reason for creating this PR is to ensure that vNext does not have this security hole in it.

Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well, I understand.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants