Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 'public' not 'listed' in comments. Implement Boolean range for . #57

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Use 'public' not 'listed' in comments. Implement Boolean range for . #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
222c17a
Create LICENSE.md
Mitzi-Laszlo Oct 3, 2019
2c37bef
Use 'public' not 'listed' in comments. Implement bollean range for .
timbl Sep 21, 2021
bd0f4b8
Merge remote-tracking branch 'origin/master' into publicNotListed
timbl Sep 21, 2021
185b2bc
Merge branch 'main' into publicNotListed
timbl Sep 21, 2021
c4ce971
Makefile for publishing
timbl Oct 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions LICENSE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Copyright 2019 - present
Copy link
Contributor

@TallTed TallTed Oct 1, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Copyright 2019 - present
Copyright 2019 - 2022 _ENTITY_
  • present is not valid in a copyright statement; specific year(s) must be listed
  • the entity claiming copyright must be identified, historically/typically with a human-focused name, potentially including or changing to a machine-focused URI such as a WebID or DID which may be dereferenced to machine- or human-focused details (a/k/a RDF)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re entity URI, let's revisit this after resolving solid/specification#412 and if still applicable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Making the following suggestion since we use it elsewhere for code/spec:

Suggested change
Copyright 2019 - present
Copyright 2019 - 2022 W3C Solid Community Group

But may be worth questioning whether the CG should hold the copyright on the repo or another entity.

We included some non-Solid-centric vocabs in this repo so to have open contributions and simplify the update process.


Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
8 changes: 8 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@


alcs:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
alcs:
acl:

cp acl.n3 ../../../www.w3.org/ns/auth

space:
cp space.n3 ../../../www.w3.org/ns/pim/
(cd ../../../www.w3.org/ns/pim/; make space.*)
22 changes: 16 additions & 6 deletions solid-terms.ttl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,27 +193,37 @@ solid:patches

solid:privateTypeIndex
a rdf:Property ;
dc:issued "2018-01-24"^^xsd:date ;
rdfs:comment "Points to an unlisted type index resource."@en ;
rdfs:comment
"""The object is to a private (unlisted) type index resource.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"""The object is to a private (unlisted) type index resource.
"""The object is a private (unlisted) type index resource.

The subject is the user's webid.
The triple in found in the private preferences file.
(which itself is pointed to from the public profile by space:preferencesFile)
"""@en ;
rdfs:range solid:UnlistedDocument ;
rdfs:isDefinedBy <http://www.w3.org/ns/solid/terms#> ;
rdfs:label "private type index"@en .

solid:publicTypeIndex
a rdf:Property ;
dc:issued "2018-01-24"^^xsd:date ;
rdfs:subPropertyOf solid:typeIndex ;
rdfs:comment "Points to a listed type index resource."@en ;
rdfs:comment """The object is to a pubic ("listed") type index resource..
Copy link
Contributor

@TallTed TallTed Sep 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rdfs:comment """The object is to a pubic ("listed") type index resource..
rdfs:comment """The object is a pubic ("listed") type index resource.

The subject is the user's webid.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The subject is the user's webid.
The subject is the user's WebID.

The triple in found in the private preferences file.
(which itself is pointed to from the public profile by space:preferencesFile)
Comment on lines +211 to +212
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The triple in found in the private preferences file.
(which itself is pointed to from the public profile by space:preferencesFile)
The triple in found in the private preferences file
(which is pointed to from the public profile by space:preferencesFile).

"""@en ;
rdfs:range solid:ListedDocument ;
rdfs:isDefinedBy <http://www.w3.org/ns/solid/terms#> ;
rdfs:label "public type index"@en .
rdfs:subPropertyOf solid:typeIndex ;
dc:issued "2018-01-24"^^xsd:date ;
rdfs:range solid:ListedDocument ;
rdfs:isDefinedBy <http://www.w3.org/ns/solid/terms#> .

solid:read
a rdf:Property ;
dc:issued "2015-12-18"^^xsd:date ;
rdfs:comment "Indicates if a message has been read or not. This property should have a boolean datatype."@en ;
rdfs:isDefinedBy <http://www.w3.org/ns/solid/terms#> ;
rdfs:domain <http://rdfs.org/sioc/ns#Post> ;
rdfs:range xsd:boolean;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rdfs:range xsd:boolean;

That can be introduced in a separate PR about solid:read.

Aside: domain sioc:Post is not particularly interesting. (Nowadays messages/notifications tend to be an as:Activity of some kind.)

rdfs:label "read"@en .

solid:storageQuota
Expand Down