Clarify append vs write to create, fix #105 #106
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #105 |
csarven
reviewed
Jun 25, 2022
There was a problem hiding this comment.
"Generally" is just an introductory - something that most readers would be presumably familiar with. It was an editorial call to not hash out HTTP request semantics here. Section #http-interactions is sufficient IMO. I don't think the spec should say too much in this paragraph at the risk of complicating things or misleading. For example, POST+Slug targeting a container would be interpreted as an append operation with a suggestion to name the resource. So, I prefer to leave it as is.
|
OK, fair enough! At least we have clarity now in these closed issues, so we can unskip the tests in question in the test suite, and update solid-contrib/test-suite#146 with the definite information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.