New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure global .gitignore to sync with git_ignore flag #231

Merged

solidiquis merged 1 commit into solidiquis:master from siqpush:siqpush/global-ignore

Jul 27, 2023

Contributor

siqpush commented Jul 22, 2023

-i, --no-ignore

Do not respect .gitignore ...and global .gitignore files

Change Summary

The issue is due to the presence of a global .gitignore file; the symlink was just the victim by chance. Currently, globally ignored files will continue to be removed regardless of flag: -i, --no-ignore. Syncing both global and local .gitignores better addresses the user request.

Change to Code

specifying git_global() method with ignore context to WalkBuilder struct to match the (-i, --no-ignore) flag's use case.


          ensure global .gitignore to sync with git_ignore flag

15df8d3

solidiquis merged commit 490f7d2 into solidiquis:master

2 checks passed

solidiquis mentioned this pull request

Symlinks sometimes not shown #208

Closed

siqpush deleted the siqpush/global-ignore branch

August 5, 2023 20:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet