fix: no-op if onScroll applied to incorrect element

solidjs-community · Oct 29, 2024 · 0a6d281 · 0a6d281
1 parent 2911fcd
commit 0a6d281
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/packages/virtual/src/index.tsx b/packages/virtual/src/index.tsx
@@ -1,6 +1,5 @@
 import { For, createSignal } from "solid-js";
 import type { Accessor, JSX } from "solid-js";
-import type { DOMElement } from "solid-js/jsx-runtime";
 import { access } from "@solid-primitives/utils";
 import type { MaybeAccessor } from "@solid-primitives/utils";
 
@@ -58,7 +57,7 @@ export function createVirtualList<T extends readonly any[]>({
     }),
     e => {
       // @ts-expect-error
-      setOffset(e.target?.scrollTop);
+      if (e.target?.scrollTop !== undefined) setOffset(e.target.scrollTop);
     },
   ];
 }