-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug?]: docs: favicon.ico is missing in prod #1235
Comments
It's very odd. I must admit. I see the file in my local builds. I presume it makes it to cloudflare and yet it doesn't get served by the static asset. |
This is what I could find out. kv-asset-handler tries to determine the type of The interessting thing is that var Mime_1 = Mime$1;
var standard = {...}
let Mime = Mime_1;
var lite = new Mime(standard); // <=== where is the others map?
var mime_1 = mime$1.exports; |
I think that is an old saved one. I still see us returning an HTML page on that request. Somehow it isn't there or isn't matching on static assets first. |
The answer was right there...🤦♂️ This was fixed for the pages preset. There is an open issue for the cloudflare preset and apperently also applies to cloudflare_module. mime/lite seems to be pulled in by unenv. Adding an alias to the full mime db like it was done for pages works around the problem. Gave it a quick try locally and worked. server: {
preset: "cloudflare_module",
alias: {
"_mime": "mime/index.js"
}
} |
As this is not pages they will probably make it lower priority. I'm going to close it here and we can just track the progress in that nitro issue. I'm glad the workaround exists. |
Duplicates
Latest version
Current behavior 😯
Expected behavior 🤔
icon should show in the browser tab
Steps to reproduce 🕹
Steps:
Context 🔦
No response
Your environment 🌎
No response
The text was updated successfully, but these errors were encountered: